Re: Patch: better implementation for "dispose" in TnyCamelAccount and TnyCamelStoreAccount

[José Dapena Paz <jdapena igalia com>]

El jue, 23-07-2009 a las 10:21 +0200, Philip Van Hoof escribió:
> On Tue, 2009-07-21 at 18:30 +0200, José Dapena Paz wrote:
> > tatic void
> > +tny_camel_account_dispose (GObject *object)
> > +{
> > +       TnyCamelAccount *self = (TnyCamelAccount *)object;
> > +       TnyCamelAccountPriv *priv = TNY_CAMEL_ACCOUNT_GET_PRIVATE
> > (self);
> > +       CamelException ex = CAMEL_EXCEPTION_INITIALISER;
> > +
> > +       if (priv->service && CAMEL_IS_SERVICE (priv->service))
> > +       {
> > +               priv->service->connecting = NULL;
> > +               priv->service->disconnecting = NULL;
> > +               priv->service->reconnecter = NULL;
> > +               priv->service->reconnection = NULL;
> > +               camel_service_disconnect (CAMEL_SERVICE
> > (priv->service), FALSE, &ex);
> 
> You are leaking and not handling ex here

	Anyway, I'm dropping this patch. This doesn't fix the issue, and may
cause hangs on shutdown process.

-- 
José Dapena Paz <jdapena igalia com>
Igalia