Re: Because we don't want Mr Van Hoof to get bored...

[Sergio Villar Senin <svillar igalia com>]

I'll commit it then. Thx for the review

Br

Rob Taylor escribiu:
> Sergio Villar Senin wrote:
>> another patch to be reviewed. I'll explain the problem and then the fix
>>
>> problem is that IMAP accounts use two queues, one for the "normal"
>> operations and another one just for message retrieval. Thing is that if
>> you have a reconnection or a connection request in the "normal" queue,
>> it could happen that the user requests a get_msg_async or a
>> find_msg_async that would be redirected to the other queue. User could
>> think that the connection will take place before but that don't have to
>> be true as both petitions go in different paths.
>>
>> What I did is add a new queue item flag called CONNECT_ITEM that
>> identifies calls to set_online function, and if the user issues a
>> get_msg_async or a find_msg_async while a CONNECT_ITEM is pending then
>> that petition will go through the "normal" queue, that's it, it'll wait
>> for the account connection.
> 
> The argument makes sense, and the patch looks good to me. Assuming
> you've tested this a bit, consider it approved.