Re: [PATCH] cachefile-fat32-comptatible

[Philip Van Hoof <spam pvanhoof be>]

Approved and committed, thanks for catching this early

On Fri, 2008-11-14 at 11:52 +0100, Thomas Guillem wrote:
> Hi,
> 
> I forgot to put a NULL at a g_build_filename argument.
> 
> Also, I think we must ignore cache files that don't end by a '.' or by
> ".~". 
> Because the cache_put function provokes glib-Critical and may seg
> fault if key and uid are the same.
> 
> Of course with my last patch, new cache files will always end by '.', by
> ".~" or by ".xxx".
> 
> I attached a patch.
> 
> Regards,
> 
> * Philip Van Hoof <spam pvanhoof be> [2008-11-13 17:44:54 +0100]:
> > Patch accepted and committed
> > 
> > Thanks!
> > 
> > On Thu, 2008-11-13 at 16:51 +0100, Thomas Guillem wrote:
> > > OK, new patch attached.
> > > 
> > > * Philip Van Hoof <spam pvanhoof be> [2008-11-13 15:50:56 +0100]:
> > > > I know that the existing code didn't do this either, but please use
> > > > g_build_filename instead of hardcoding the directory separator as '/'
> > > > for new code and patches.
> > > > 
> > > > On Thu, 2008-11-13 at 15:25 +0100, Thomas Guillem wrote:
> > > > > Hi,
> > > > > 
> > > > > The attached patch change cache filename in order to be compatible with
> > > > > FAT32 Partions, like we discussed on IRC.
> > > > > 
> > > > > Is it OK ?
> > > > > 
> > 
> > -- 
> > Philip Van Hoof, freelance software developer
> > home: me at pvanhoof dot be 
> > gnome: pvanhoof at gnome dot org 
> > http://pvanhoof.be/blog
> > http://codeminded.be
> > 
> 
-- 
Philip Van Hoof, freelance software developer
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
http://pvanhoof.be/blog
http://codeminded.be