Re: [PATCH] typo in the idle_sleep comment

[Philip Van Hoof <spam pvanhoof be>]

Approved and thanks a lot!

On Mon, 2008-11-10 at 12:19 +0100, José Dapena Paz wrote:
> El jue, 06-11-2008 a las 19:58 +0100, Philip Van Hoof escribió:
> > José, can you pick this up?
> > 
> > It's IDLE code ;-)
> > 
> > Note that the ideal IDLE sleep time is 27 minutes as default, indeed.
> > 
> > That's because most IMAP servers have a timeout of 30 minutes.
> 
> 	Yes, it's interesting, as this timeout of 6.75 minutes has been there
> for more than a year. I assumed that it was there for an special reason
> (you know, IMAP, standards and implementations unfortunately don't match
> always).
> 
> 	As discussed in IRC, it seems a typo. For avoiding future problems, I'm
> sending this patch to clarify the default times and ticks for IDLE
> implementation. It should set again 28 minutes, but also show clearly
> the way it's calculated. It should also fix the idle delay parameter
> processing.
> 
> Changelog would be:
> * Specify with defines the IDLE tick time (time between iterations in
>   idle loop) and IDLE default delay (time between IDLE/DONE cycles if no
>   event happens).
> * Fix the IDLE delay account parameter to take into account the tick
>   time.

-- 
Philip Van Hoof, freelance software developer
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
http://pvanhoof.be/blog
http://codeminded.be