Re: Patch: Camel stream filter waits properly for slow streams
- From: Philip Van Hoof <spam pvanhoof be>
- To: José Dapena Paz <jdapena igalia com>
- Cc: Matthew Barnes <mbarnes redhat com>, evolution-patches <evolution-patches gnome org>, Evolution Hackers <evolution-hackers gnome org>, tinymail-devel-list <tinymail-devel-list gnome org>, Jeffrey Stedfast <fejj novell com>
- Subject: Re: Patch: Camel stream filter waits properly for slow streams
- Date: Tue, 20 May 2008 18:49:32 +0200
José has no GNOME-svn account. I can commit on behalf of José if this
patch is approved.
Please let us know if it's approved.
Thanks!
On Tue, 2008-05-20 at 18:38 +0200, José Dapena Paz wrote:
> El mar, 20-05-2008 a las 17:03 +0200, Philip Van Hoof escribió:
> > Please bring this upstream too, José
> >
> > Response from Jeffrey:
> >
> > jeff_ yea, you should compare against -1
> > jeff_ as long as it returns >0, it wrote all the data
> > jeff_ -1 is error
> > jeff_ 0 is EOF maybe
> > jeff_ if write even returns 0 ever
>
> Ok, prepared patch for camel (it applied without problems). The
> changelog would be mostly the same:
>
> * evolution-data-server/camel/camel-stream-filter.c:
> (do_write): if the camel_stream_write call does not write the
> full buffer but it's not due to an error, then loop to go on
> writing the stream.
>
>
--
Philip Van Hoof, freelance software developer
home: me at pvanhoof dot be
gnome: pvanhoof at gnome dot org
http://pvanhoof.be/blog
http://codeminded.be
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]