Re: Patch: add weak references to current_folder, old_folder and last_folder in imap store

[Philip Van Hoof <spam pvanhoof be>]

Approved

On Tue, 2008-05-06 at 17:36 +0200, José Dapena Paz wrote:
> El mar, 06-05-2008 a las 14:50 +0200, Philip Van Hoof escribió:
> > Prepend the private symbols with an underscore, use a -priv.h file, and
> > then this is approved.
> 
> 	New version of the patch, with the recommendations. Changelog entry
> would be this time:
> * libtinymail-camel/camel-lite/camel/providers/imap/camel-imap-store.[ch]:
>         * Now references to current_folder, old_folder and last_folder
>           are weak references. This way, when they're finalized we
>           properly remove the store reference to them.
>         * Removed some small leaks and compilation warnings.
> * libtinymail-camel/camel-lite/camel/providers/imap/camel-imap-store-priv.h:
> 	* Added. Includes internal declarations of weak reference handlers
> 	  for folders in the imap store.
> * libtinymail-camel/camel-lite/camel/providers/imap/camel-imap-command.c,
>   libtinymail-camel/camel-lite/camel/providers/imap/camel-imap-folder.c:
>         * Use weak references to folders in accesses to store.
> 
> > 
> > 
> > On Tue, 2008-05-06 at 13:57 +0200, José Dapena Paz wrote:
> > > 	Hi,
> > > 
> > > 	This patch adds weak references to current_folder, old_folder and
> > > last_folder in imap store, to make them be removed when the objects are
> > > finalized. This should prevent some crashes and memory corruptions
> > > caused by accessing these folders after they're freed.
> > > 
> > > 	The patch does not include Changelog entry. It would be:
> > > 
> > > * libtinymail-camel/camel-lite/camel/providers/imap/camel-imap-store.[ch]:
> > > 	* Now references to current_folder, old_folder and last_folder
> > > 	  are weak references. This way, when they're finalized we
> > > 	  properly remove the store reference to them.
> > > 	* Removed some small leaks and compilation warnings.
> > > * libtinymail-camel/camel-lite/camel/providers/imap/camel-imap-command.c,
> > >   libtinymail-camel/camel-lite/camel/providers/imap/camel-imap-folder.c:
> > > 	* Use weak references to folders in accesses to store.
> > > _______________________________________________
> > > tinymail-devel-list mailing list
> > > tinymail-devel-list gnome org
> > > http://mail.gnome.org/mailman/listinfo/tinymail-devel-list
-- 
Philip Van Hoof, freelance software developer
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
http://pvanhoof.be/blog
http://codeminded.be