Re: Patch for updating attachments when we know about, and some thoughts

[Philip Van Hoof <spam pvanhoof be>]

Fix what we discussed on IRC and then go ahead and commit.

Make sure to use svn mv bs camel-lite, don't delete and add it again,
use the mv command of svn.

Thanks!

On Tue, 2008-03-04 at 11:11 +0100, Jose Dapena Paz wrote:
> 	Hi,
> 
> 	I added an implementation for updating the attachments flag in
> TnyCamelMsg when we know if the message has parts with content
> disposition = attachment. It would give us at least more precission
> evaluating if we have attachments, in case we already have the full
> message.
> 
> 	I'll use this mail to explain some tests and thoughts I about this
> problem.
> 	* First, I agree with Philip, in the fact that we really don't take a
> good improvement on using the multipart/mixed heuristics to establish
> that we have attachments (it would fail for many crypted/signed
> messages, and also for some mailing lists that attach their signature as
> an additional part).
> 	* I tested a draft implementation for fetching the bodystructure of all
> the messages with multipart/mixed in a separate query. It gives accurate
> results, but it's slow and adds a connection overload that I don't like
> for mobile / expensive connections.
> 	* Then, the solution would be modifying the imap backend to use
> bodystructure and envelope (first for fetching the mime structure
> information, second for fetching the headers information). It's a
> complex change, involving updates to storage, likely to be done with the
> work in the new storage Philip has sent.
> 
> 	To use the bodystructure parser in camel code, I moved it in the build
> structure. This change will be also in this patch. It's not used now as
> I'm not committing the changes in camel imap folder, but sure it will be
> if we implement the bodystructure/envelope based fetcher in tinymail.
> 
> 	Ok, and now the changelog entry:
> 
> 	* libtinymail-camel/tny-camel-mime-part.c:
> 	Now, when we get the parts of a mime part that's a message,
> 	we check if any part has an attachment content disposition,
> 	and update the attachments flag properly.
> 	* Moved bodystructure parser to camel, so that we
> 	can use it there.
> 	* libtinymail-camel/camel-lite/bs/bodystruct.c:
> 	Added missing if, to avoid fetching the header badly (and
> 	causing coredumps) for bodystructure strings not
> 	including BODYSTRUCTURE prefix.
> 
> _______________________________________________
> tinymail-devel-list mailing list
> tinymail-devel-list gnome org
> http://mail.gnome.org/mailman/listinfo/tinymail-devel-list
-- 
Philip Van Hoof, freelance software developer
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
http://pvanhoof.be/blog
http://codeminded.be