Re: Patch: fix some bad weak reference code in CamelImapStore
- From: José Dapena Paz <jdapena igalia com>
- To: tinymail-devel-list <tinymail-devel-list gnome org>
- Subject: Re: Patch: fix some bad weak reference code in CamelImapStore
- Date: Mon, 21 Jul 2008 11:46:15 +0200
El lun, 21-07-2008 a las 11:38 +0200, José Dapena Paz escribió:
> Hi,
>
> This is a trivial fix for a bad weak reference code in CamelImapStore
> (we add/remove a reference to the wrong object).
>
> Changelog would be:
> * libtinymail-camel/camel-lite/camel/providers/imap/camep-imap-store.c:
> Trivial fix for current folder weak reference code.
Better if I attach the patch :).
>
--
José Dapena Paz <jdapena igalia com>
Igalia
Index: libtinymail-camel/camel-lite/camel/providers/imap/camel-imap-store.c
===================================================================
--- libtinymail-camel/camel-lite/camel/providers/imap/camel-imap-store.c (revision 3721)
+++ libtinymail-camel/camel-lite/camel/providers/imap/camel-imap-store.c (working copy)
@@ -2832,7 +2832,7 @@
CamelException local_ex;
imap_store->current_folder = new_folder;
- camel_object_hook_event (imap_store, "finalize",
+ camel_object_hook_event (imap_store->current_folder, "finalize",
_camel_imap_store_current_folder_finalize, imap_store);
/* camel_object_ref (new_folder); */
camel_exception_init (&local_ex);
@@ -2841,7 +2841,7 @@
if (camel_exception_is_set (&local_ex)) {
camel_exception_xfer (ex, &local_ex);
/* camel_object_unref (imap_store->current_folder); */
- camel_object_unhook_event (imap_store, "finalize",
+ camel_object_unhook_event (imap_store->current_folder, "finalize",
_camel_imap_store_current_folder_finalize, imap_store);
imap_store->current_folder = NULL;
camel_object_unref (new_folder);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]