RE: tiny patch for camel-imap-store-summary.c

[Philip Van Hoof <spam pvanhoof be>]

Yep, this is indeed a typo (s = s will of course not do what we want it
to do).

Approved, good catch. Thanks.


On Thu, 2008-01-10 at 16:11 +0200, Dirk-Jan Binnema nokia com wrote:
> (and with the patch)
> 
> > -----Original Message-----
> > From: tinymail-devel-list-bounces gnome org 
> > [mailto:tinymail-devel-list-bounces gnome org] On Behalf Of 
> > ext Dirk-Jan C. Binnema
> > Sent: Thursday, January 10, 2008 16:08
> > To: tinymail-devel-list gnome org
> > Subject: tiny patch for camel-imap-store-summary.c
> > 
> > Hi Philip,
> > 
> > I got these valgrind warnings, apparently related to the recently
> > added namespace code:
> > 
> >  Thread 1:
> > ==17533== Use of uninitialised value of size 4
> > ==17533==    at 0x5F6E44E: namespace_clear
> > (camel-imap-store-summary.c:529)
> > ==17533==    by 0x5F6D7F9: camel_imap_store_summary_finalise
> > (camel-imap-store-summary.c:108)
> > ==17533==    by 0x42883EF: camel_object_unref (camel-object.c:920)
> > ==17533==    by 0x5F6461E: camel_imap_store_finalize
> > (camel-imap-store.c:403)
> > ==17533==    by 0x42883EF: camel_object_unref (camel-object.c:920)
> > ==17533==    by 0x5F5CEDC: check_gmsgstore_die
> > (camel-imap-folder.c:4347)
> > ==17533==    by 0x4BBEC95: g_timeout_dispatch (gmain.c:3422)
> > ==17533==    by 0x4BBC1FB: g_main_context_dispatch (gmain.c:2045)
> > ==17533==    by 0x4BBDBB4: g_main_context_iterate (gmain.c:2677)
> > ==17533==    by 0x4BBDED9: g_main_loop_run (gmain.c:2881)
> > ==17533==    by 0x46DC172: gtk_main (gtkmain.c:1155)
> > ==17533==    by 0x80747A9: main (modest-main.c:157)
> > 
> > It seems we trying to free an unitialized is->namespaces there.
> > I think it's due to a typo... see the patch.
> > 
> > Can I apply?
> > 
> > Best wishes,
> > Dirk.

-- 
Philip Van Hoof, freelance software developer
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
http://pvanhoof.be/blog
http://codeminded.be