Re: Patch: better heuristics for detecting attachments in headers in imap



On Fri, 2008-02-29 at 16:51 +0100, Philip Van Hoof wrote:
> On Fri, 2008-02-29 at 09:32 +0100, Jose Dapena Paz wrote:
> 
> > 	We also unref the message we use to get information later, to analyse
> > properly the headers of the message.
> 
> That removal of the unref is actually a simple memory leak (a huge one),
> and therefore incorrect.

Ah no, I didn't notice that you added an unref later. Nonetheless is
multipart/mixed not sufficient.


-- 
Philip Van Hoof, freelance software developer
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
http://pvanhoof.be/blog
http://codeminded.be






[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]