Re: Patch: better heuristics for detecting attachments in headers in imap
- From: Philip Van Hoof <spam pvanhoof be>
- To: Jose Dapena Paz <jdapena igalia com>
- Cc: tinymail-devel-list <tinymail-devel-list gnome org>
- Subject: Re: Patch: better heuristics for detecting attachments in headers in imap
- Date: Fri, 29 Feb 2008 16:50:52 +0100
I don't accept this patch as multipart/mixed is not sufficient as an
heuristic to determine whether or not a message has an attachment.
On Fri, 2008-02-29 at 09:32 +0100, Jose Dapena Paz wrote:
> Hi,
>
> This patch improves a bit the heuristics to know if a message has
> attachments inside. It retrieves the content type obtained in imap, and,
> if it's a multipart/mixed, then we assume the message has attachments.
>
> We also unref the message we use to get information later, to analyse
> properly the headers of the message.
>
> Changelog entry:
> * libtinymail-camel/camel-lite/camel/providers/imap/camel-imap-folder.c:
> (message_from_data): improve the heuristics to know if a message has
> attachments. First, we don't unref the message too early, so we can
> analyse the message headers. Second, we use the content type. If it's
> a multipart/mixed, then we assume it has attachments.
>
> _______________________________________________
> tinymail-devel-list mailing list
> tinymail-devel-list gnome org
> http://mail.gnome.org/mailman/listinfo/tinymail-devel-list
--
Philip Van Hoof, freelance software developer
home: me at pvanhoof dot be
gnome: pvanhoof at gnome dot org
http://pvanhoof.be/blog
http://codeminded.be
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]