Patch: set_pass_func always reactivate account



	Hi,

	This patch modifies a bit the behavior of
tny_camel_account_set_pass_func. It makes it always do the account
activation, even when we're setting again the same pass func as before.
As we only activate the account after going through a set func, this let
us reconfigure an account after first setup.

Changelog entry:
* libtinymail-camel/tny-camel-account.c:
(tny_camel_account_set_pass_func_default) reactivate the account
always, even when we're setting the same pass func again.
-- 
Jose Dapena Paz <jdapena igalia com>
Igalia
Index: m4/gtk-doc.m4
===================================================================
--- m4/gtk-doc.m4	(revision 3436)
+++ m4/gtk-doc.m4	(working copy)
@@ -9,22 +9,22 @@
   AC_BEFORE([AC_PROG_LIBTOOL],[$0])dnl setup libtool first
   AC_BEFORE([AM_PROG_LIBTOOL],[$0])dnl setup libtool first
   dnl for overriding the documentation installation directory
-  AC_ARG_WITH([html-dir],
-    AS_HELP_STRING([--with-html-dir=PATH], [path to installed docs]),,
+  AC_ARG_WITH(html-dir,
+    AC_HELP_STRING([--with-html-dir=PATH], [path to installed docs]),,
     [with_html_dir='${datadir}/gtk-doc/html'])
   HTML_DIR="$with_html_dir"
-  AC_SUBST([HTML_DIR])
+  AC_SUBST(HTML_DIR)
 
   dnl enable/disable documentation building
-  AC_ARG_ENABLE([gtk-doc],
-    AS_HELP_STRING([--enable-gtk-doc],
-                   [use gtk-doc to build documentation [[default=no]]]),,
-    [enable_gtk_doc=no])
+  AC_ARG_ENABLE(gtk-doc,
+    AC_HELP_STRING([--enable-gtk-doc],
+                   [use gtk-doc to build documentation [default=no]]),,
+    enable_gtk_doc=no)
 
   have_gtk_doc=no
   if test x$enable_gtk_doc = xyes; then
     if test -z "$PKG_CONFIG"; then
-      AC_PATH_PROG([PKG_CONFIG], [pkg-config], [no])
+      AC_PATH_PROG(PKG_CONFIG, pkg-config, no)
     fi
     if test "$PKG_CONFIG" != "no" && $PKG_CONFIG --exists gtk-doc; then
       have_gtk_doc=yes
@@ -36,9 +36,9 @@
     if test "$have_gtk_doc" = yes; then
       AC_MSG_CHECKING([gtk-doc version >= $gtk_doc_min_version])
       if $PKG_CONFIG --atleast-version $gtk_doc_min_version gtk-doc; then
-        AC_MSG_RESULT([yes])
+        AC_MSG_RESULT(yes)
       else
-        AC_MSG_RESULT([no])
+        AC_MSG_RESULT(no)
         have_gtk_doc=no
       fi
     fi
@@ -48,6 +48,6 @@
     fi
   fi
 
-  AM_CONDITIONAL([ENABLE_GTK_DOC], [test x$enable_gtk_doc = xyes])
-  AM_CONDITIONAL([GTK_DOC_USE_LIBTOOL], [test -n "$LIBTOOL"])
+  AM_CONDITIONAL(ENABLE_GTK_DOC, test x$enable_gtk_doc = xyes)
+  AM_CONDITIONAL(GTK_DOC_USE_LIBTOOL, test -n "$LIBTOOL")
 ])
Index: libtinymail-camel/tny-camel-account.c
===================================================================
--- libtinymail-camel/tny-camel-account.c	(revision 3436)
+++ libtinymail-camel/tny-camel-account.c	(working copy)
@@ -1045,10 +1045,6 @@
 	gboolean reconf_if = FALSE;
 	gboolean changed = FALSE;
 
-	/* Ignore this if it is not a change: */
-	if (get_pass_func == priv->get_pass_func)
-		return;
-
 	g_static_rec_mutex_lock (priv->service_lock);
 
 	if (priv->get_pass_func != get_pass_func)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]