Patch: missing else causing crashes in pop3 backend



	Hi,

	I found a missing else in a condition check that could cause crashes
due to freeing summary message info entries when they shouldn't.

Changelog entry:
* libtinymail-camel/camel-lite/camel/providers/pop3/camel-pop3-folder.c:
Added a missing else that could cause freeing some summary info entries
when they shouldn't
-- 
Jose Dapena Paz <jdapena igalia com>
Igalia
Index: libtinymail-camel/camel-lite/camel/providers/pop3/camel-pop3-folder.c
===================================================================
--- libtinymail-camel/camel-lite/camel/providers/pop3/camel-pop3-folder.c	(revision 3425)
+++ libtinymail-camel/camel-lite/camel/providers/pop3/camel-pop3-folder.c	(working copy)
@@ -1243,7 +1243,7 @@
 		if (had_attachment)
 			camel_message_info_set_flags((CamelMessageInfo *) mi, CAMEL_MESSAGE_ATTACHMENTS, CAMEL_MESSAGE_ATTACHMENTS);
 		camel_folder_summary_add (summary, (CamelMessageInfo *)mi);
-	} if (mi) {
+	} else if (mi) {
 		if (had_attachment)
 			camel_message_info_set_flags((CamelMessageInfo *) mi, CAMEL_MESSAGE_ATTACHMENTS, CAMEL_MESSAGE_ATTACHMENTS);
 		camel_message_info_free (mi);
Index: ChangeLog
===================================================================
--- ChangeLog	(revision 3425)
+++ ChangeLog	(working copy)
@@ -9,6 +9,10 @@
  	Now we don't send the run-queue-stop signal until
  	we've processed all sent signals.
 
+	* libtinymail-camel/camel-lite/camel/providers/pop3/camel-pop3-folder.c:
+	Added a missing else that could cause freeing some summary info entries
+	when they shouldn't
+
 2008-02-20  Philip Van Hoof <pvanhoof gnome org>
 
 	* Improvement for cancel's their reconnection


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]