Patch: remove unnecesary camel exception checks
- From: José Dapena Paz <jdapena igalia com>
- To: tinymail-devel-list <tinymail-devel-list gnome org>
- Subject: Patch: remove unnecesary camel exception checks
- Date: Fri, 12 Dec 2008 19:24:37 +0100
Hi,
This patch removes some unnecesary camel exception checks in
TnyCamelAccountStore. As far as I can see, they only act on the
exception as started by CAMEL EXCEPTION INITIALIZER. Then, they should
be "no op".
Changelog would be:
* libtinymail-camel/tny-camel-account-store.c: removed unnecesary camel
exception checks.
--
José Dapena Paz <jdapena igalia com>
Igalia
diff --git a/libtinymail-camel/tny-camel-store-account.c b/libtinymail-camel/tny-camel-store-account.c
index 533abb7..c4b6639 100644
--- a/libtinymail-camel/tny-camel-store-account.c
+++ b/libtinymail-camel/tny-camel-store-account.c
@@ -871,14 +871,6 @@ tny_camel_store_account_remove_folder_actual (TnyFolderStore *self, TnyFolder *f
store = CAMEL_STORE (apriv->service);
- if (camel_exception_is_set (&ex))
- {
- _tny_camel_exception_to_tny_error (&ex, err);
- camel_exception_clear (&ex);
- _tny_session_stop_operation (apriv->session);
- return;
- }
-
g_assert (CAMEL_IS_STORE (store));
g_static_rec_mutex_lock (aspriv->factory_lock);
@@ -1109,14 +1101,6 @@ tny_camel_store_account_create_folder_default (TnyFolderStore *self, const gchar
store = CAMEL_STORE (apriv->service);
- if (camel_exception_is_set (&ex))
- {
- _tny_camel_exception_to_tny_error (&ex, err);
- camel_exception_clear (&ex);
- _tny_session_stop_operation (apriv->session);
- return NULL;
- }
-
g_assert (CAMEL_IS_STORE (store));
info = camel_store_create_folder (store, NULL, name, &ex);
@@ -1382,14 +1366,6 @@ tny_camel_store_account_get_folders_default (TnyFolderStore *self, TnyList *list
store = CAMEL_STORE (apriv->service);
- if (camel_exception_is_set (&ex))
- {
- _tny_camel_exception_to_tny_error (&ex, err);
- camel_exception_clear (&ex);
- _tny_session_stop_operation (apriv->session);
- return;
- }
-
g_assert (CAMEL_IS_STORE (store));
flags = CAMEL_STORE_FOLDER_INFO_FAST | CAMEL_STORE_FOLDER_INFO_NO_VIRTUAL |
@@ -1639,14 +1615,6 @@ tny_camel_store_account_store_refresh (TnyFolderStore *self, GError **err)
store = CAMEL_STORE (apriv->service);
- if (camel_exception_is_set (&ex))
- {
- _tny_camel_exception_to_tny_error (&ex, err);
- camel_exception_clear (&ex);
- _tny_session_stop_operation (apriv->session);
- return;
- }
-
g_assert (CAMEL_IS_STORE (store));
flags = CAMEL_STORE_FOLDER_INFO_FAST | CAMEL_STORE_FOLDER_INFO_NO_VIRTUAL |
@@ -1988,14 +1956,6 @@ tny_camel_store_account_find_folder_default (TnyStoreAccount *self, const gchar
store = CAMEL_STORE (apriv->service);
- if (camel_exception_is_set (&ex))
- {
- _tny_camel_exception_to_tny_error (&ex, err);
- camel_exception_clear (&ex);
- _tny_session_stop_operation (apriv->session);
- return NULL;
- }
-
g_assert (CAMEL_IS_STORE (store));
flags = CAMEL_STORE_FOLDER_INFO_FAST | CAMEL_STORE_FOLDER_INFO_NO_VIRTUAL;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]