Re: [PATCH 06/18] Fix ref leak with the iter_store in tny_camel_store_account.



On Fri, 2008-08-29 at 17:42 +0100, Rob Taylor wrote:
> Fix ref leak with the iter_store in tny_camel_store_account.

Not approved, why aren't you unreferencing priv->iter_store but instead
are you unreferencing store?

Not making sense to me ...

+
+       if (priv->iter_store) {
+               camel_object_unref (CAMEL_OBJECT (store));
+       }
        camel_object_ref (CAMEL_OBJECT (store));
        priv->iter_store = store;


> ---
>   libtinymail-camel/tny-camel-store-account.c |    4 ++++
>   1 files changed, 4 insertions(+), 0 deletions(-)


-- 
Philip Van Hoof, freelance software developer
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
http://pvanhoof.be/blog
http://codeminded.be






[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]