Re: [PATCHES] Some patches I've been brewing..

[Philip Van Hoof <spam pvanhoof be>]

Hey Rob,

This is just a mail to make it official that Sergio Villar can approve
these patches. Hereby it's also official that reviews you do for
Sergio's patches, are approved too.

So go ahead and do some cross-fertilization!

I will post-review too, but I will do the ones Sergio (or you) has
already reviewed less thoroughly.

Thanks for this work! Awesome stuff!

Philip


On Fri, 2008-08-29 at 17:37 +0100, Rob Taylor wrote:
> Here's a sequence of patches I've been brewing up for a while.
> It includes a much more solid and tested verion of the TnyFolderStore
> api change I proposed a while back ([PATCHES] Serious TnyFolderStore api
> change and new functionality, 12/06/08).
> 
> My apologies for dropping these all in one go, I've only just found the 
> time to get them together into sane patches..
> 
> Enjoy and thanks,
> Rob
> 
> -----
> 
> Rob Taylor (18):
>    Do unrefs in dispose, not finalise for tny-camel-folder and
>      tny-camel-store-account.
>    Give tny_folder_store_get_folders a refresh parameter, for optionally
>      not refreshing from the server.
>    New observer behaviour. Observers will get folders_appeared events
>      when a
>    Change all usage of tny_folder_store_get_folders over to the new api
>    Attempt to fix the queue<->account refcount loop in a thread safe
>      way.
>    Fix ref leak with the iter_store in tny_camel_store_account.
>    Add tny_camel_queue_stop, to allow an application to request that all
>    Correctly change the unread and total message numbers after a
>      status_poke
>    Don't leak CamelCertDB after camel_shutdown.
>    Make TnySendQueue interface depend on TnyFolderStore
>    Add tny_camel_send_queue_new_with_folders to create a
>      TnyCamelSendQueue with user-created folders
>    Create TnyMergeFolderStore. This merges together multiple
>      TnyFolderStores to create one read-only TnyFolderStore.
>    In pop3 provider, do a LIST before a folder sync so failure doesnt
>      happen if wait_for_login_delay kills the store
>    Make the sofar/oftotal field in TnyProgress more sensible when one of
>      the is negative.
>    In TnyCamelFolder don't emit folder store change on observer
>      attachment if there's no folders.
>    Fix saving and loading of namespaces in the summary.
>    Fix some valgrind warnings in camel imap provider.
>    Make account_store weak-referenced in TnySessionCamel.
> 
>   ChangeLog                                          |   53 ++-
>   libtinymail-camel/Makefile.am                      |    6 +-
>   libtinymail-camel/camel-lite/camel/camel.c         |    3 +
>   .../camel/providers/imap/camel-imap-folder.c       |    5 +-
>   .../providers/imap/camel-imap-message-cache.c      |    5 +
>   .../providers/imap/camel-imap-store-summary.c      |   19 +-
>   .../providers/imap/camel-imap-store-summary.h      |   14 +-
>   .../camel/providers/imap/camel-imap-store.c        |  101 +++-
>   .../camel/providers/pop3/camel-pop3-folder.c       |   49 ++
>   libtinymail-camel/observer-mixin.c                 |  183 +++++
>   libtinymail-camel/observer-mixin.h                 |   41 ++
>   libtinymail-camel/tny-camel-account.c              |   26 +
>   libtinymail-camel/tny-camel-account.h              |    5 +-
>   libtinymail-camel/tny-camel-folder-priv.h          |    1 +
>   libtinymail-camel/tny-camel-folder.c               |  418 ++++++++++-
>   libtinymail-camel/tny-camel-folder.h               |    4 +-
>   libtinymail-camel/tny-camel-queue-priv.h           |    9 +-
>   libtinymail-camel/tny-camel-queue.c                |  116 +++-
>   libtinymail-camel/tny-camel-send-queue-priv.h      |    3 +
>   libtinymail-camel/tny-camel-send-queue.c           |  381 ++++++++++-
>   libtinymail-camel/tny-camel-send-queue.h           |    2 +
>   libtinymail-camel/tny-camel-store-account-priv.h   |    1 +
>   libtinymail-camel/tny-camel-store-account.c        |  433 +++++++++++-
>   libtinymail-camel/tny-camel-store-account.h        |    4 +-
>   libtinymail-camel/tny-session-camel.c              |   31 +-
>   libtinymail/Makefile.am                            |    7 +-
>   libtinymail/observer-mixin.c                       |  196 ++++++
>   libtinymail/observer-mixin.h                       |   42 ++
>   libtinymail/tny-combined-account.c                 |   17 +-
>   libtinymail/tny-folder-store-change.c              |   81 ++-
>   libtinymail/tny-folder-store-change.h              |    5 +-
>   libtinymail/tny-folder-store.c                     |   34 +-
>   libtinymail/tny-folder-store.h                     |   10 +-
>   libtinymail/tny-merge-folder-store.c               |  739
> ++++++++++++++++++++
>   libtinymail/tny-merge-folder-store.h               |   72 ++
>   libtinymail/tny-progress-info.c                    |   15 +-
>   libtinymail/tny-send-queue.c                       |    2 +
>   libtinymail/tny-shared.h                           |    1 +
>   .../tny-gtk-folder-store-tree-model.c              |    6 +-
>   tests/c-demo/tny-demoui-summary-view.c             |    4 +-
>   tests/functional/account-refresh.c                 |    3 +-
>   tests/functional/
> 
> 
-- 
Philip Van Hoof, freelance software developer
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
http://pvanhoof.be/blog
http://codeminded.be