Fixes for several memory leaks in the merge folder

[Sergio Villar Senin <svillar igalia com>]

Hi,

find attached the patch that properly free the info structures used as
helpers for thread executions in the TnyMergeFolder. We're leaking every
single structure we're using.

Br

Index: libtinymail/tny-merge-folder.c
===================================================================
--- libtinymail/tny-merge-folder.c	(revision 3738)
+++ libtinymail/tny-merge-folder.c	(working copy)
@@ -201,8 +201,7 @@
 			remove_msgs_async_destroyer (info);
 		}
 	} else { /* Thread reference */
-		g_object_unref (info->self);
-		g_object_unref (info->headers);
+		remove_msgs_async_destroyer (info);
 	}
 
 	g_thread_exit (NULL);
@@ -217,7 +216,7 @@
 	RemMsgsInfo *info;
 	GThread *thread;
 
-	info = g_slice_new (RemMsgsInfo);
+	info = g_slice_new0 (RemMsgsInfo);
 	info->err = NULL;
 	info->self = self;
 	info->headers = headers;
@@ -412,8 +411,9 @@
 			sync_async_callback (info);
 			sync_async_destroyer (info);
 		}
-	} else /* Thread reference */
-		g_object_unref (self);
+	} else { /* Thread reference */
+		sync_async_destroyer (info);
+	}
 
 	g_thread_exit (NULL);
 
@@ -427,7 +427,7 @@
 	SyncFolderInfo *info;
 	GThread *thread;
 
-	info = g_slice_new (SyncFolderInfo);
+	info = g_slice_new0 (SyncFolderInfo);
 	info->err = NULL;
 	info->self = self;
 	info->expunge = expunge;
@@ -604,8 +604,9 @@
 			get_msg_async_callback (info);
 			get_msg_async_destroyer (info);
 		}
-	} else /* thread reference */
-		g_object_unref (info->self);
+	} else { /* thread reference */
+		get_msg_async_destroyer (info);
+	}
 
 	g_thread_exit (NULL);
 
@@ -619,7 +620,7 @@
 	GetMsgInfo *info;
 	GThread *thread;
 
-	info = g_slice_new (GetMsgInfo);
+	info = g_slice_new0 (GetMsgInfo);
 	info->self = self;
 	info->header = header;
 	info->callback = callback;
@@ -711,8 +712,9 @@
 			find_msg_async_callback (info);
 			find_msg_async_destroyer (info);
 		}
-	} else /* thread reference */
-		g_object_unref (info->self);
+	} else { /* thread reference */
+		find_msg_async_destroyer (info);
+	}
 
 	g_thread_exit (NULL);
 
@@ -726,7 +728,7 @@
 	FindMsgInfo *info;
 	GThread *thread;
 
-	info = g_slice_new (FindMsgInfo);
+	info = g_slice_new0 (FindMsgInfo);
 	info->self = self;
 	info->url_string = g_strdup (url_string);
 	info->callback = callback;
@@ -842,8 +844,7 @@
 			get_headers_async_destroyer (info);
 		}
 	} else { /* Thread reference */
-		g_object_unref (info->self);
-		g_object_unref (info->headers);
+		get_headers_async_destroyer (info);
 	}
 
 	g_thread_exit (NULL);
@@ -858,7 +859,7 @@
 	GetHeadersFolderInfo *info;
 	GThread *thread;
 
-	info = g_slice_new (GetHeadersFolderInfo);
+	info = g_slice_new0 (GetHeadersFolderInfo);
 	info->err = NULL;
 	info->self = self;
 	info->headers = headers;
@@ -1245,8 +1246,9 @@
 			refresh_async_callback (info);
 			refresh_async_destroyer (info);
 		}
-	} else /* Thread reference */
-		g_object_unref (self);
+	} else {
+		refresh_async_destroyer (info);
+	}
 
 	g_thread_exit (NULL);
 
@@ -1260,7 +1262,7 @@
 	RefreshFolderInfo *info;
 	GThread *thread;
 
-	info = g_slice_new (RefreshFolderInfo);
+	info = g_slice_new0 (RefreshFolderInfo);
 	info->err = NULL;
 	info->self = self;
 	info->callback = callback;
@@ -1379,9 +1381,7 @@
 			transfer_msgs_async_destroyer (info);
 		}
 	} else  { /* Thread reference */
-		g_object_unref (info->self);
-		g_object_unref (info->folder_dst);
-		g_object_unref (info->header_list);
+		transfer_msgs_async_destroyer (info);
 	}
 
 	g_thread_exit (NULL);
@@ -1395,7 +1395,7 @@
 	TransferMsgsInfo *info;
 	GThread *thread;
 
-	info = g_slice_new (TransferMsgsInfo);
+	info = g_slice_new0 (TransferMsgsInfo);
 	info->err = NULL;
 	info->self = self;
 	info->callback = callback;