Re: (Patch) Add support for LibCST to tinymail camel

[Philip Van Hoof <spam pvanhoof be>]

o. gtk-doc.m4 diff is included in the patch (I don't see why these
   changes are necessary)
o. Same for camel-mime-part-utils.c
o. The changes in camel-tcp-stream-ssl.c are not ifdeffed under HAVE_CST
o. This lock:

+static void
+camel_certdb_finalize (CamelObject *obj)
+{
+	CamelCertDB *certdb = (CamelCertDB *) obj;
+	struct _CamelCertDBPrivate *p;
+
+	p = certdb->priv;
+
+	g_free (certdb->filename);
+
+	g_mutex_lock (certdb->priv->db_lock);
+	CST_save (p->cst);
+	CST_free (p->cst);

This must be unlock, I suppose?

+	g_mutex_lock (certdb->priv->db_lock);
+
+	g_mutex_free (p->db_lock);
+	g_mutex_free (p->io_lock);
+	g_mutex_free (p->alloc_lock);
+	g_mutex_free (p->ref_lock);
+
+	g_free (p);
+}



On Wed, 2008-04-09 at 13:56 +0200, José Dapena Paz wrote:
> 	Hi,
> 
> 	This patch adds support for using CST as certificate repository in
> camel (tinymail camel backend). CST is the common certificate repository
> available in Nokia maemo-based internet tablets.
> 
> 	It's implemented as a fast hack to avoid a big rework of the currently
> working implementation.
> 
> 	Of course, it seems all the certdb stuff should be refactored to allow
> multiple backends (CST, file certdb, mozilla, whatever). But this adds
> provisional support.
> 
> 	About autotools stuff, it only enables the cst support if available and
> you use nss ssl implementation (I didn't implement the openssl side
> support for camel-certdb-cst, so I'm not sure if it's working).
> 
> Changelog entry:
> * Added libtinymail-camel/camel-lite/camel/camel-certdb-cst.c.
>   Implementation of certificates database using maemo libcst. This
>   makes you can manage certificates using the maemo tablet certificate
>   manager.
> * libtinymail-camel/camel-lite/camel/camel-certdb.h,
>   libtinymail-camel/camel-lite/camel/camel-private.h: modified to
>   have a pointer to the CST object in certdb and certificate id in
>   certificate object in case we compile with CST support.
> * libtinymail-camel/camel-lite/camel/camel-tcp-stream-ssl.c:
>   Modified a bit the code for proper integration with cst (mainly
>   removing direct access to internal fields).
> * libtinymail-camel/camel-lite/configure.ac,
>   libtinymail-camel/camel-lite/camel/Makefile.am:
>   Added support for detection and configuration of libcst.
> 
> _______________________________________________
> tinymail-devel-list mailing list
> tinymail-devel-list gnome org
> http://mail.gnome.org/mailman/listinfo/tinymail-devel-list
-- 
Philip Van Hoof, freelance software developer
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
http://pvanhoof.be/blog
http://codeminded.be