Re: Tinymail hangs when cancelling a connection

[Philip Van Hoof <spam pvanhoof be>]

Approved. Please commit


On Tue, 2007-11-20 at 18:25 +0100, Sergio Villar Senin wrote:
> Hi,
> 
> I've just discovered that tinymail hangs when issuing two connections in 
> a row using tny_camel_account_set_online. The error could be seen in 
> this trace
> 
> Thread 1 (Thread 1076438432 (LWP 2956)):
> #0  0x4071e334 in pthread_cond_wait@@GLIBC_2.4 () from /lib/libpthread.so.0
> #1  0x400f3a30 in on_set_online_done (self=0x177100, account=0x18b240, 
> err=0x308098, user_data=0x2b6d58)
>      at tny-camel-account.c:1726
> #2  0x400f945c in cancelled_conn (user_data=0x2ffc30) at 
> tny-camel-store-account.c:1777
> #3  0x40dd2098 in g_idle_dispatch (source=0xfffffffc, 
> callback=0x400f93dc <cancelled_conn>, user_data=0x0)
>      at gmain.c:3928
> #4  0x40dce570 in IA__g_main_context_dispatch (context=0xd6a20) at 
> gmain.c:2045
> #5  0x40dd043c in g_main_context_iterate (context=0xd6a20, block=1, 
> dispatch=1, self=0x0) at gmain.c:2677
> #6  0x40dd07b4 in IA__g_main_loop_run (loop=0xbf658) at gmain.c:2881
> #7  0x408b63d8 in IA__gtk_main () at gtkmain.c:1155
> #8  0x0002da30 in main (argc=1, argv=0xbea9d6d4) at modest-main.c:158
> #9  0x40e5010c in __libc_start_main () from /lib/libc.so.6
> #10 0x0001f830 in _start ()
> 
> You see it? The cancelled_conn is issued in an idle, and it calls 
> execute_callback with depth 10, which means that the user callback will 
> be called in an idle. After that it waits in a GCond. What happens is 
> that the idle with the call to the user callback will never happen 
> because the main loop is actually stopped in the g_cond_wait, so the 
> g_cond_wait will wait forever. It's a simple fix for this, just to call 
> the execute_callback with depth 0 if the connection was cancelled. See 
> the patch attached.
> 
> Br
> _______________________________________________
> tinymail-devel-list mailing list
> tinymail-devel-list gnome org
> http://mail.gnome.org/mailman/listinfo/tinymail-devel-list
-- 
Philip Van Hoof, freelance software developer
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
http://pvanhoof.be/blog
http://codeminded.be