Re: Tinymail patches

[Philip Van Hoof <spam pvanhoof be>]

Hey Steve,

I will try to merge your patches as good as possible in trunk and they
should be available the next pre release (0.0.6) in the official
tarball.

Regarding your question about Conic: I replied this message to our
mailing list too,and I've put the libtinymail-maemo maintainer in CC.

The libtinymail-maemo platform target might be suitable for Ubuntu
Mobile releases.


On Tue, 2007-11-20 at 13:41 +1100, Steve Kowalik wrote:
> Hi Philip,
> 
> 	I've been packaging up Tinymail for inclusion in Ubuntu, and thought
> I'd drop you a mail about a few patches I've had to apply. One of the
> patches I won't attach, since it can be explained easily.
> 
> 	The first patch is against libtinymailui-gnome-keyring/Makefile.{am,in}
> to add -fPIC -DPIC to the AM_CFLAGS since libtinymailui links against a
> library built with PIC on amd64. I'm attaching a patch direct from the
> packaging, so there's a little administrivia at the top.
> 
> 	The second patch is a copy of tny-maemo-device-priv.h from SVN, which
> doesn't seem to have made it into the tarballs, but seems to be needed
> when building.
> 
> 	Now that I've got the patches out of the way, I've got a query. The
> -maemo build now pulls in conic. Is there a way to disable that?
> --disable-conic doesn't do it, since it still wants to link against the
> conic headers.
> 
> Thanks,
> plain text document attachment
> (libtinymailui-gnome-keyring-fpic.dpatch)
> #! /bin/sh /usr/share/dpatch/dpatch-run
> ## libtinymailui-gnome-keyring-fpic.dpatch by Steve Kowalik <stevenk ubuntu com>
> ##
> ## All lines beginning with `## DP:' are a description of the patch.
> ## DP: Add -fPIC to AM_CFLAGS for -gnome-keyring, and re-run automake.
> 
> @DPATCH@
> diff -urNad libtinymail-0.0.2~/libtinymailui-gnome-keyring/Makefile.am libtinymail-0.0.2/libtinymailui-gnome-keyring/Makefile.am
> --- libtinymail-0.0.2~/libtinymailui-gnome-keyring/Makefile.am	2007-10-03 15:40:50.000000000 +1000
> +++ libtinymail-0.0.2/libtinymailui-gnome-keyring/Makefile.am	2007-10-04 12:03:31.000000000 +1000
> @@ -1,3 +1,5 @@
> +AM_CFLAGS = -fPIC -DPIC
> +
>  INCLUDES = -I. -I$(top_srcdir) \
>  	$(TINYMAIL_CFLAGS) \
>  	$(LIBTINYMAILUI_GTK_CFLAGS) \
> diff -urNad libtinymail-0.0.2~/libtinymailui-gnome-keyring/Makefile.in libtinymail-0.0.2/libtinymailui-gnome-keyring/Makefile.in
> --- libtinymail-0.0.2~/libtinymailui-gnome-keyring/Makefile.in	2007-09-19 06:33:46.000000000 +1000
> +++ libtinymail-0.0.2/libtinymailui-gnome-keyring/Makefile.in	2007-10-04 12:03:48.000000000 +1000
> @@ -290,6 +290,7 @@
>  subdirs = @subdirs@
>  sysconfdir = @sysconfdir@
>  target_alias = @target_alias@
> +AM_CFLAGS = -fPIC -DPIC
>  INCLUDES = -I. -I$(top_srcdir) $(TINYMAIL_CFLAGS) \
>  	$(LIBTINYMAILUI_GTK_CFLAGS) -I$(top_srcdir)/libtinymail \
>  	-I$(top_srcdir)/libtinymailui \
-- 
Philip Van Hoof, freelance software developer
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
http://pvanhoof.be/blog
http://codeminded.be