Re: That was a long night ...

[Sergio Villar Senin <svillar igalia com>]

Philip Van Hoof wrote:
> But I think tny_folder_copy actually works now. The model seems to be
> getting updated too.
> 
> Although it's not not-complex :-\
> 
> I also tested some error situations and hardened the implementation
> against all sorts of abnormalities a little bit.
> 
> It can use a couple of reviews, though.
> 
I think there is something wrong because I get a SIGSEV when trying to
refresh a folder after using the async version in a situation where I
know that the folder move is not possible. I got nothing with the sync
version in the same situation.

The error returned by tinymail to the callback of the folder copy is
(gdb) print (*err)->message
$1 = (
    gchar *) 0x8232600 "You should not use this operation with del=TRUE
while the folder is still in use. There are still 3 users of this
folder. This problem indicates a bug in the software."

I know that this problem exist in my software, and that I should fix it,
but maybe tinymail is doing something else wrong because see what gdb
says when trying to refresh a folder after the failed copy operation (as
you can see I'm cleaning the old model of a header view widget setting a
NULL one)

#0  0xb7de5993 in camel_message_info_free (o=0x81def80) at
camel-folder-summary.c:3153
#1  0xb7e225b8 in tny_camel_header_finalize (object=0x821eb78) at
tny-camel-header.c:295
#2  0xb7040b61 in g_object_unref () from /usr/lib/libgobject-2.0.so.0
#3  0xb6faf4aa in g_ptr_array_foreach () from /usr/lib/libglib-2.0.so.0
#4  0xb7c457c2 in tny_gtk_header_list_model_finalize (object=0x81e7ae0)
at tny-gtk-header-list-model.c:817
#5  0xb7040b61 in g_object_unref () from /usr/lib/libgobject-2.0.so.0
#6  0xb7886c44 in gtk_tree_model_sort_set_model
(tree_model_sort=0x81d9ed0, child_model=0x0) at gtktreemodelsort.c:1877
#7  0xb7886df3 in gtk_tree_model_sort_finalize (object=0x81d9ed0) at
gtktreemodelsort.c:345
#8  0xb7040b61 in g_object_unref () from /usr/lib/libgobject-2.0.so.0
#9  0xb78a9105 in IA__gtk_tree_view_set_model (tree_view=0x81a2018,
model=0x0) at gtktreeview.c:11183

Br