RE: Priorities and attachments

[Philip Van Hoof <spam pvanhoof be>]

On Fri, 2007-03-23 at 16:58 +0200, Dirk-Jan Binnema nokia com wrote:

ps. re-adding the mailing list

> That looks fine; unless someone needs something finer-grained than
> important/not-important.

I doubt that.

> >-----Original Message-----
> 
> <snip>
> 
> >	else {
> >		attach = camel_header_raw_find(&h, 
> >"Content-Type", NULL);
> >		if (g_strstr_len (attach, strlen (attach), 
> >"multi") != NULL)
> >			mi->flags |= CAMEL_MESSAGE_ATTACHMENTS;
> >	}
> 
> Note that you probably need to do a case-insensitive match for
> all of these cases in the strstr; (camel_header_raw_find *is*
> case-insensitive).

Yes, you are right. It should be a strcasestr. But I'm not yet sure
whether the Content-Type is the best header for this. I'll ask around
first.

> (BTW, I noticed that eg. tny_mime_part_has_content_type does not
>  match case-insensitively)

I'm already waiting for your patch :) (I think it should do it case
insensitively and have it documented that way).

-- 
Philip Van Hoof, software developer
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
http://www.pvanhoof.be/blog