Re: tny-merge-folder observer notification
- From: Murray Cumming <murrayc murrayc com>
- To: Armin Burgmeier <armin arbur net>
- Cc: tinymail-devel-list gnome org
- Subject: Re: tny-merge-folder observer notification
- Date: Fri, 06 Jul 2007 15:58:17 +0200
There are warnings that need to be fixed. For instance, this passes a
TnyFolderObserver* to tny_folder_change_new() though that expects a
TnyFolder*:
static void
tny_merge_folder_update (TnyFolderObserver *self, TnyFolderChange
*change)
{
TnyFolderChange* new_change = tny_folder_change_new (self);
On Thu, 2007-07-05 at 18:58 +0200, Armin Burgmeier wrote:
> Hi tinymail developers,
>
> Currently, TnyMergeFolder observes its underlaying folders and
> propagates any TnyFolderChanges to its own observers without
> modification. However, since those observers actually observe the
> TnyMergeFolder (and not necessarily the underlaying folders) it seems
> more correct when the changed folder for the TnyFolderChange is set to
> the TnyMergeFolder before propagating. Also, if an underlaying folder is
> renamed it does not affect the merge folder itself.
>
> I prepared a patch to change the behaviour as described. This also fixes
> projects.maemo.org bug NB#59369.
>
> Thanks,
> Armin
> _______________________________________________
> tinymail-devel-list mailing list
> tinymail-devel-list gnome org
> http://mail.gnome.org/mailman/listinfo/tinymail-devel-list
--
Murray Cumming
murrayc murrayc com
www.murrayc.com
www.openismus.com
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]