Some bugs



Hi,

I think there is a missing unlock in the TnyCamelMimePart. See attached.

And the TnyGtkFolderStore was incorrectly initialized, because it was
configured to work in sync mode always.

Br.
Index: libtinymail-camel/tny-camel-mime-part.c
===================================================================
--- libtinymail-camel/tny-camel-mime-part.c	(revision 1462)
+++ libtinymail-camel/tny-camel-mime-part.c	(working copy)
@@ -98,8 +98,10 @@
 
 	containee = camel_medium_get_content_object (CAMEL_MEDIUM (priv->part));
 	
-	if (G_UNLIKELY (containee == NULL))
+	if (G_UNLIKELY (containee == NULL)) {
+		g_mutex_unlock (priv->part_lock);
 		return;
+	}
 
 	if (CAMEL_IS_MULTIPART (containee))
 	{
Index: libtinymailui-gtk/tny-gtk-folder-store-tree-model.c
===================================================================
--- libtinymailui-gtk/tny-gtk-folder-store-tree-model.c	(revision 1462)
+++ libtinymailui-gtk/tny-gtk-folder-store-tree-model.c	(working copy)
@@ -211,7 +211,7 @@
 tny_gtk_folder_store_tree_model_new (gboolean async, TnyFolderStoreQuery *query)
 {
 	TnyGtkFolderStoreTreeModel *self = g_object_new (TNY_TYPE_GTK_FOLDER_STORE_TREE_MODEL, NULL);
-	self->is_async = FALSE;
+	self->is_async = async;
 	if (query) self->query = g_object_ref (G_OBJECT (query));
 	return GTK_TREE_MODEL (self);
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]