Re: Small fix
- From: Philip Van Hoof <spam pvanhoof be>
- To: Sergio Villar Senin <svillar igalia com>
- Cc: tinymail-devel-list gnome org
- Subject: Re: Small fix
- Date: Wed, 14 Feb 2007 18:44:30 +0100
On Wed, 2007-02-14 at 17:26 +0100, Sergio Villar Senin wrote:
> Hi,
>
> seems that the stream is in a bad place, isn't it?
>
No, yes well.
The intention is to check for store->istream in stead of "stream".
But I'll fix this because the code which you patched was indeed wrong.
>
> Index: camel-lite/camel/providers/imap/camel-imap-store.c
> ===================================================================
> --- camel-lite/camel/providers/imap/camel-imap-store.c (revisión: 1634)
> +++ camel-lite/camel/providers/imap/camel-imap-store.c (copia de trabajo)
> @@ -3468,12 +3468,12 @@
> *dest = NULL;
>
> g_mutex_lock (store->stream_lock);
> + stream = CAMEL_STREAM_BUFFER (store->istream);
> if (stream == NULL || ((CamelObject *)stream)->ref_count <= 0)
> {
> g_mutex_unlock (store->stream_lock);
> return -1;
> }
> - stream = CAMEL_STREAM_BUFFER (store->istream);
> ba = g_byte_array_new ();
> while ((nread = camel_tcp_stream_buffer_gets_nb (stream,
> linebuf, sizeof (linebuf))) > 0)
> {
> _______________________________________________
> tinymail-devel-list mailing list
> tinymail-devel-list gnome org
> http://mail.gnome.org/mailman/listinfo/tinymail-devel-list
--
Philip Van Hoof, software developer
home: me at pvanhoof dot be
gnome: pvanhoof at gnome dot org
http://www.pvanhoof.be/blog
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]