Re: Patch: use internal folder summary cache always
- From: Philip Van Hoof <spam pvanhoof be>
- To: Jose Dapena Paz <jdapena igalia com>
- Cc: tinymail-devel-list <tinymail-devel-list gnome org>
- Subject: Re: Patch: use internal folder summary cache always
- Date: Sat, 22 Dec 2007 11:52:12 +0100
This is wrong. The reason is that the rec-mutex is not really a
rec-mutex but a malloc() (you do g_new0). A rec-mutex-free is for normal
static rec mutexes, it seems.
What you must use here is a normal g_free. Take a look at the other rec
mutexes in tinymail. At some point I fixed all of them.
The rest looks fine afaics.
On Fri, 2007-12-21 at 19:53 +0100, Jose Dapena Paz wrote:
> - g_mutex_free(s->hash_lock);
> + g_static_rec_mutex_free(s->hash_lock);
--
Philip Van Hoof, freelance software developer
home: me at pvanhoof dot be
gnome: pvanhoof at gnome dot org
http://pvanhoof.be/blog
http://codeminded.be
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]