Re: About tny-mime-part-write-to-stream

[Philip Van Hoof <spam pvanhoof be>]

These interface wrappers don't return after your patch, yet the
return-type is a ggsize. So the returned value will always be 0. I don't
think that's what you want, right?


On Thu, 2007-12-20 at 19:58 +0100, Felipe Erias Morandeira wrote:
> -void
> -tny_mime_part_write_to_stream (TnyMimePart *self, TnyStream *stream)
> +gssize
> +tny_mime_part_write_to_stream (TnyMimePart *self, TnyStream *stream, GError **err)
>  {
>  #ifdef DBC /* require */
>         g_assert (TNY_IS_MIME_PART (self));
> @@ -631,7 +633,7 @@
>         g_assert (TNY_MIME_PART_GET_IFACE (self)->write_to_stream_func != NULL);
>  #endif
>  
> -       TNY_MIME_PART_GET_IFACE (self)->write_to_stream_func (self, stream);
> +       TNY_MIME_PART_GET_IFACE (self)->write_to_stream_func (self, stream, err);
>         return;
>  }
>  
> @@ -674,11 +676,13 @@
>   * }
>   * </programlisting></informalexample>
>   *
> + * returns (null-ok): Returns %-1 on error, or the number of bytes succesfully
> + * copied across streams.
>   * since: 1.0
>   * audience: application-developer
>   **/
> -void
> -tny_mime_part_decode_to_stream (TnyMimePart *self, TnyStream *stream)
> +gssize
> +tny_mime_part_decode_to_stream (TnyMimePart *self, TnyStream *stream, GError **err)
>  {
>  #ifdef DBC /* require */
>         g_assert (TNY_IS_MIME_PART (self));
> @@ -687,7 +691,7 @@
>         g_assert (TNY_MIME_PART_GET_IFACE (self)->decode_to_stream_func != NULL);
>  #endif
>  
> -       TNY_MIME_PART_GET_IFACE (self)->decode_to_stream_func (self, stream);
> +       TNY_MIME_PART_GET_IFACE (self)->decode_to_stream_func (self, stream, err);
>         return;
>  }
-- 
Philip Van Hoof, freelance software developer
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
http://pvanhoof.be/blog
http://codeminded.be