Uninitialized variable in camel-imap-command.c



This is causing lots of warnings like this in Valgrind

==31666== Conditional jump or move depends on uninitialised value(s)
==31666==    at 0x61AF13E: camel_imap_command_response (camel-imap-command.c:509)
==31666==    by 0x61B2E1B: imap_rescan (camel-imap-folder.c:1242)
==31666==    by 0x61B2108: camel_imap_folder_selected (camel-imap-folder.c:753)
==31666==    by 0x61B26CD: imap_refresh_info (camel-imap-folder.c:913)
==31666==    by 0x457E23B: disco_refresh_info (camel-disco-folder.c:268)
==31666==    by 0x45909F8: camel_folder_refresh_info (camel-folder.c:396)
[ ... ]

-- 
Alberto García González
http://people.igalia.com/berto/
Index: libtinymail-camel/camel-lite/camel/providers/imap/camel-imap-command.c
===================================================================
--- libtinymail-camel/camel-lite/camel/providers/imap/camel-imap-command.c	(revision 3165)
+++ libtinymail-camel/camel-lite/camel/providers/imap/camel-imap-command.c	(working copy)
@@ -473,7 +473,7 @@
 {
 	CamelImapResponseType type;
 	char *respbuf;
-	int len;
+	int len = -1;
 
 	if (camel_imap_store_readline (store, &respbuf, ex) < 0) {
 		CAMEL_SERVICE_REC_UNLOCK (store, connect_lock);
Index: ChangeLog
===================================================================
--- ChangeLog	(revision 3165)
+++ ChangeLog	(working copy)
@@ -1,3 +1,8 @@
+2007-12-20  Alberto Garcia Gonzalez  <agarcia igalia com>
+
+	* libtinymail-camel/camel-lite/camel/providers/imap/camel-imap-command.c:
+	(camel_imap_command_response): Set an initial value to variable len
+
 2007-12-20 Dirk-Jan C. Binnema <dirk-jan binnema nokia com>
 
 	* tny-maemo-conic-device.c; fix for typo in


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]