Re: patch to fix tny_camel_msg_header_date_(sent|received)
- From: Philip Van Hoof <spam pvanhoof be>
- To: Dirk-Jan Binnema nokia com
- Cc: tinymail-devel-list gnome org
- Subject: Re: patch to fix tny_camel_msg_header_date_(sent|received)
- Date: Fri, 31 Aug 2007 12:54:28 +0200
Yes, thanks for the patch
On Fri, 2007-08-31 at 13:48 +0300, Dirk-Jan Binnema nokia com wrote:
> Attached patch fixes tny_camel_msg_header_date_(sent|received),
> which was return the wrong time in most cases.
>
> There were some issues: it tried to normalize to GMT while
> camel already did that, so the resulting time was of by a
> couple of hours. [ Note that the function actually *added*
> the timezone, but of course it needed to be subtracted
> instead. ]
>
> Also, we are now favouring the 'received' date for received
> date if we can get it, instead of 'Date:' which is set by
> the sender. See the comment in the code.
>
> Now, the date we get in the header view is still wrong,
> (that uses tny_camel_header_get_date_(received|sent), which
> it gets from the summary), looking at that now.
>
> Can I commit?
>
--
Philip Van Hoof, software developer
home: me at pvanhoof dot be
gnome: pvanhoof at gnome dot org
http://www.pvanhoof.be/blog
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]