Re: New API function to remove n messages
- From: Sergio Villar Senin <svillar igalia com>
- To: tinymail-devel-list gnome org
- Subject: Re: New API function to remove n messages
- Date: Tue, 28 Aug 2007 18:22:18 +0200
Patch approved Javi, please commit it and do not forget the Changelog.
Br
Javier Fernandez wrote:
> El mar, 28-08-2007 a las 17:48 +0200, Sergio Villar Senin escribió:
>> Javier Fernandez wrote:
>>> El mar, 28-08-2007 a las 12:52 +0200, Javier Fernandez escribió:
>>>> I have implemented a new API function to remove multiple messages
>>>> in a single camel operation.
>>>>
>>>> Thanks for review it.
>>> I forgot the attachment, sorry.
>> The patch looks pretty good, just two questions:
>>
>> 1) why do you need it?
>
> Current function (tny_folder_remove_msg) calls folder observers
> notification method one time per message. In addition, several internal
> operations in camel could be reused for a set of message. This new
> function improve performance of operations which delete several
> messages.
>
>> 2) could you please remove the "printf" debug code ;-) ?
>
> Yes, of course.
>
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]