Re: A series of fixed memory problems



On Sun, 2006-06-04 at 13:33 +0200, Philip Van Hoof wrote:

> o. Removing an account from gconf-editor now correctly clears *all* mem-
> ory used by that account. The mistake was in tny-summary-window.c, in
> the reload_accounts method: it didn't take the real model out of the
> sort model to destroy it. 

Hmm, It didn't solve the entire issue. There's still memory being kept
back when removing an account that has, for example, a huge folder open.

If somebody is into getting this fixed, please assist me as I'm not
finding the problem ;). I've been logging things, and afaik are all
instances being destroyed (both the folder and the header instances).
Yet doesn't valgrind show this. Or, it does show "a" memory decrease,
but not everything. Something like: the part that tinymail itself
consumes, not the camel part (or visa versa). Yet when logging I'm
seeing it unreference the camel instances.

So maybe the camel instance reference counting is wrong at some obscure
location?

Valgrind shows a full memory decrease when selecting a new folder (which
in essence does exactly the same. The difference is that when an account
with an open folder gets removed, the view gets an empty model).

The account stuff has not been developed with the same purist mind as
the header stuff. So I'm not excluding bugs from my part ;).

Anyway, you can still depend on account-removing code. As I'm definitely
going to find this problem. I have declared war to the problem.

-- 
Philip Van Hoof, software developer at x-tend 
home: me at pvanhoof dot be 
gnome: pvanhoof at gnome dot org 
work: vanhoof at x-tend dot be 
http://www.pvanhoof.be - http://www.x-tend.be




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]