Re: [system-tools] Possible bug in network backend (-d list_ifaces)

[Carlos Garnacho <garnacho tuxerver net>]

Hi Juan Luis! :)

On Wed, 2004-07-07 at 01:05 +0000, Juan Luis Baptiste wrote:
> Hi,
> 
> I was playing arround with the network backend with the list_ifaces directive 
> in an unsupported platform and I have found the following behavior:
> 
> If I run ./network-conf -d list_ifaces , I get the following output:
> 
> network - platform_unsup::Your platform [mandrake-11] is not supported.

man, mandrake 11 has been already released? distros are really releasing
new versions faster than what I'm able to port them :)

> <?xml version='1.0' encoding='UTF-8' standalone='yes'?>
> <!DOCTYPE network-ifaces []>
> 
> <network-ifaces>
> 
>   <interface>
>     <active>1</active>
>     <addr>127.0.0.1</addr>
>     <dev>lo</dev>
>     <mask>255.0.0.0</mask>
>   </interface>
> 
>   <interface>
>     <active>1</active>
>     <addr>192.168.1.2</addr>
>     <bcast>192.168.1.255</bcast>
>     <dev>eth0</dev>
>     <hwaddr>00:09:6B:53:FE:90</hwaddr>
>     <mask>255.255.255.0</mask>
>   </interface>
> 
> </network-ifaces>
> 
> <!-- GST: end of request -->
> 
> But if I add the --platform parameter, I get this:
> ./network-conf -d list_ifaces --platform mandrake-9.2
> 
> <?xml version='1.0' encoding='UTF-8' standalone='yes'?>
> <!DOCTYPE network-ifaces []>
> 
> <network-ifaces>
> 
> </network-ifaces>
> 
> <!-- GST: end of request -->
> 
> Shouldn't this command show the same output than the first one? and why, if 
> the platform is unsupported is showing a correct output? is this a bug? it 
> seems to me, IMO.

It's indeed a bug, thanks for pointing this out, the fix is already
commited in the CVS, I'm attaching the patch (against HEAD) in the case
you need it for KNetworkconf :)

	Thanks for pointing this out

> 
> 
> Cheers,

? backends
Index: general.pl.in
===================================================================
RCS file: /cvs/gnome/setup-tools-backends/general.pl.in,v
retrieving revision 1.44
diff -u -r1.44 general.pl.in
--- general.pl.in	31 Dec 2003 22:21:12 -0000	1.44
+++ general.pl.in	7 Jul 2004 14:15:21 -0000
@@ -374,7 +374,6 @@
       print STDERR "Error: Unrecognized option '$arg'.\n\n";
       &gst_print_usage (\%tool, 1);
     }
-
   }
   
   # See if debug requested in env.
@@ -383,6 +382,7 @@
   
   # Set up subsystems.
 
+  &gst_platform_get_system (\%tool);
   &gst_platform_guess (\%tool) if !$tool{"platform"};
   &gst_report_begin ();
 
Index: platform.pl.in
===================================================================
RCS file: /cvs/gnome/setup-tools-backends/platform.pl.in,v
retrieving revision 1.55
diff -u -r1.55 platform.pl.in
--- platform.pl.in	17 May 2004 22:36:48 -0000	1.55
+++ platform.pl.in	7 Jul 2004 14:15:41 -0000
@@ -352,19 +352,19 @@
   return -1;
 }
 
-sub gst_platform_guess
+sub gst_platform_get_system
 {
   my ($tool) = @_;
-  local *FD;
 
   # get the output of 'uname -s', it returns the system we are running
-  *FD = &gst_file_run_pipe_read ("uname -s");
-  $$tool{"system"} = <FD>;
+  $$tool{"system"} = &gst_file_run_backtick ("uname -s");
   chomp ($$tool{"system"});
-  close FD;
+}
+
+sub gst_platform_guess
+{
+  my ($tool) = @_;
 
-  # set $gst_dist and $gst_dist_version
-  
   my %check = (
     # Red Hat check must run after Mandrake and Fedora
     "Linux" => [ \&check_lsb,      \&check_debian,   \&check_caldera, \&check_suse,