Re: [Setup-tool-hackers] [PATCH] Progress towards makingusers-admin work on FBSD

[Theo van Klaveren <t vanklaveren student utwente nl>]

On Mon, 2002-09-02 at 22:48, Carlos Garnacho wrote:
>         Hi Theo,
> 
>         Almost everything seems alright, excluding:
> 
>         - in @login_def_names, I think you shouldn't remove
> "/etc/adduser.conf", it's used by debian

Oops, that line shouldn't have been there. Actually adduser.conf exists
on FreeBSD, I think I added adduser.conf to that line myself a long time
ago. Could be that Debian uses it too.

>         - there is a ~= that should be =~

Small last-minute typo. Fixed.

>         - I'd thank you if you respect the 2 spaces tab width (just for
> not making the code more messy than it is :-) )

Uh, the original code uses spaces and tabs intermingled, so I changed
the patch to use spaces (which seems to be what you want).

>         When you solve these little issues, you may commit.A little
> patch for your patch is attached.

Committed. Thanks for your time,

 - Theo

-- 
Theo van Klaveren <t.vanklaveren@student.utwente.nl>
http://home.student.utwente.nl/t.vanklaveren


_______________________________________________
setup-tool-hackers maillist  -  setup-tool-hackers@ximian.com
http://lists.ximian.com/mailman/listinfo/setup-tool-hackers