Re: [Setup-tool-hackers] [PATCH] Progress towards makingusers-admin work on FBSD



        Hi Theo,

        Almost everything seems alright, excluding:

        - in @login_def_names, I think you shouldn't remove
"/etc/adduser.conf", it's used by debian

        - there is a ~= that should be =~

        - I'd thank you if you respect the 2 spaces tab width (just for
not making the code more messy than it is :-) )

        When you solve these little issues, you may commit.A little
patch for your patch is attached.

                Thanks for your help



--- xst-users-in.diff	2002-09-02 18:41:46.000000000 +0200
+++ xst-users-in2.diff	2002-09-02 21:02:11.000000000 +0200
@@ -30,7 +30,7 @@
  @shadow_names =     ( "/etc/shadow", "/etc/master.passwd" );
  @group_names =      ( "/etc/group" );
 -@login_defs_names = ( "/etc/login.defs", "/etc/adduser.conf" );
-+@login_defs_names = ( "/etc/login.defs", "/etc/pw.conf" );
++@login_defs_names = ( "/etc/login.defs", "/etc/pw.conf", "/etc/adduser.conf" );
  @shell_names =      ( "/etc/shells" );
  @skel_dir =         ( "/usr/share/skel", "/etc/skel" );
  
@@ -92,7 +92,7 @@
 -	
 -	$command = "$cmd_userdel -r \'" . $$data[$users_prop_map{"login"}] . "\'";
 +
-+	if ($xst_dist ~= /^freebsd/) {
++	if ($xst_dist =~ /^freebsd/) {
 +		$command = "$cmd_pw userdel -r -n \'" . $$data[$users_prop_map{"login"}] . "\' ";
 +	} else {
 +		$command = "$cmd_userdel -r \'" . $$data[$users_prop_map{"login"}] . "\'";

Esta parte del mensaje esta firmada digitalmente



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]