Re: [Setup-tool-hackers] Speed problems in the tools.

[Hans Petter Jansson <hpj ximian com>]

> I was using the Ximian Setup Tools, and I noticed that "applying" a
> change took way too much time.  I tracked down the problem, and it was
> due to processing on the file descriptor handler the input from the
> backend one character at a time.
> 
> Indeed, it processed one character on each invocation of the handler.
> This was obviously extremely inneficient (there was a fixme there,
> that said `it wont be too slow, because it is not too much data', but
> even in this case it was plain inneficient).
> 
> Also, it seems like someone is trying to implement its own version of
> the string handling routines, there is no reason to do so.  Please use
> GString for this, not only it makes the code easier to read, it is an
> API that has already been debugged.
> 
> I fixed the problem, and fixed some very broken code at the same time
> (the magic "102k maximum of configuration" trick is gone).
> 
> Patch is attached.

Good to have it fixed. We're applying and testing this today.

--
Hans Petter

_______________________________________________
setup-tool-hackers maillist  -  setup-tool-hackers@ximian.com
http://lists.ximian.com/mailman/listinfo/setup-tool-hackers