[Setup-tool-hackers] perl -w

[Michael Meeks <michael ximian com>]

Hi there,

	Since it looks like I will have less time to fool around with
xst, this might be a parting shot - however, everyone I have spoken to,
including the perl man page say something like:

	The -w switch produces some lovely diagnostics.
or:
	-w TURN WARNINGS ON FOR COMPILATION OF YOUR SCRIPT. Recommended.

	So - I have this contoversial plan :-)

	Lets turn warnings on ... 'env' seems to make this slightly
more difficult, but not impossible I suspect. Either way, here are a
batch of minor -w type issues, none of them looking that serious (
after all it works doesn't it :-):

Scalar value @args[0] better written as $args[0] at
/opt/gnome/share/ximian-setup-tools/scripts/general.pl line 171.
...
Parens missing around "my" list at
/opt/gnome/share/ximian-setup-tools/scripts/util.pl line 127.
...
Useless use of a variable in void context at
/opt/gnome/share/ximian-setup-tools/scripts/util.pl line 127.
...
Scalar value @_[0] better written as $_[0] at
/opt/gnome/share/ximian-setup-tools/scripts/util.pl line 247.
...
Scalar value @ip_reg1[0] better written as $ip_reg1[0] at
/opt/gnome/share/ximian-setup-tools/scripts/util.pl line 250.
...
Scalar value @ip_reg1[0] better written as $ip_reg1[0] at
/opt/gnome/share/ximian-setup-tools/scripts/util.pl line 273.
...
Useless use of a variable in void context at
/opt/gnome/share/ximian-setup-tools/scripts/file.pl line 314.
...
Reference found where even-sized list expected at
/opt/gnome/share/ximian-setup-tools/scripts/file.pl line 412.
...
\1 better written as $1 at
/opt/gnome/share/ximian-setup-tools/scripts/parse.pl line 140.
...
print on closed filehandle main::FILE at
/opt/gnome/share/ximian-setup-tools/scripts/debug.pl line 45.
...
Use of uninitialized value at
/opt/gnome/share/ximian-setup-tools/scripts/parse.pl line 284.
...
print on closed filehandle main::FILE at
/opt/gnome/share/ximian-setup-tools/scripts/debug.pl line 45.
...

	Anyone feel like taking them on ? the facility is quite
useless with so many low level sillies in there.

		Michael.

-- 
 mmeeks@gnu.org  <><, Pseudo Engineer, itinerant idiot


_______________________________________________
setup-tool-hackers maillist  -  setup-tool-hackers@helixcode.com
http://lists.helixcode.com/mailman/listinfo/setup-tool-hackers