[Setup-tool-hackers] boot-conf patch and some questions...



Hi all, 

	As I said some time ago, boot-admin didn't add (nor remove) any entry
in my lilo.conf, here's the patch (I hope to have done it right). And
here are the questions:

	1) Why does boot-conf check the distro in order to know which boot
loader is someone using? What should happen if I have a distro which
uses lilo and I change to grub? I think that boot-conf should check
config files before checking the distro in order to know which boot
loader is in use.

	2) What happened with runlevel-admin? I expected opinions, bugs...
--- boot-lilo.pl.in.orig	Fri Mar 22 00:10:23 2002
+++ boot-lilo.pl.in	Fri Mar 22 00:14:03 2002
@@ -419,7 +419,7 @@
 {
   my ($entry, $buff, $lineno) = @_;
 
-  my $known_vars = \@lilo_image_vars if (exists $entry->{'entry'});
+  my $known_vars = \@lilo_image_vars if (exists $entry->{'image'});
   $known_vars = \@lilo_other_vars if (!$known_vars && exists $entry->{'other'});
   return $buff unless $known_vars;
   
@@ -507,10 +507,10 @@
   my ($line, $key, $value, $known_vars);
 
   # Entry line
-  if (exists $entry->{'entry'})
+  if (exists $entry->{'image'})
   {
     $known_vars = \@lilo_image_vars;
-    $value = 'entry';
+    $value = 'image';
   }
   elsif (exists $entry->{'other'})
   {
@@ -555,7 +555,7 @@
 
 sub xst_boot_lilo_entries_set
 {
-  my ($file, $key, $entries) = @_;
+  my ($file, $entries) = @_;
   my ($buff, $lineno, $found, $entry);
 
   return if (scalar @$entries <= 0);
@@ -579,7 +579,7 @@
           
         if ($found > 0)
         {
-          # Found entry, change it if neccecary,
+          # Found entry, change it if necessary,
           # remove %entry from @entries and find new entry.
           &xst_boot_lilo_edit_entry ($entry, $buff, $lineno);
           $entry = undef;

This is a digitally signed message part



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]