Re: [Shotwell] Adding face recognition to shotwell



Hi Jens,

I agree that we should not be forcing the DNN model download for everyone. It could be an optional 'data' package which is required only for face recognition and not detection. This data package could probably be under a different license like you said.
So I will assume the basic facedetect binary would be packaged with shotwell, with a dbus service hook to launch it.

On Wednesday, 18 July, 2018, 8:40:16 PM IST, Jens Georg <mail jensge org> wrote:



> So do we now create 2 packages out of the shotwell tree? How would the
> facedetect package be published to various distributions?
> And should the facedetect binary become a service which can be
> launched by shotwell, or maybe by the OS?


You should not care about this at all. Either me (for flatpak) or
whoever is responsible for the distribution packages.

Being D-Bus (and running on the public busses) automatic launching comes
for free with D-Bus activation, given the D-Bus service files are
installed properly. But we can do that in a second step.

The more problematic thing I see here is that I would not like to
force everyone to download 31Mb of data for a feature they are probably
not even using

The other issue is that I have a vague memory of Apache + GPL being a
bit
of a problem. So probably the face detect binary might have to go into a
separate, differently licensed package that uses D-Bus for "license
isolation"
anyway.

Let me have a look at the code first, though.



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]