rename-window change

[Christopher Roy Bratusek <zanghar freenet de>]

Hi all,

@ Proposed Goals, Teika suggested rename-window to rewrite _NET_WM_VISIBLE_NAME rather
than _NET_WM_NAME. But: this does have no effect here. Either way here's a patch for
rename-window against HEAD:

diff --git a/lisp/sawfish/wm/windows.jl b/lisp/sawfish/wm/windows.jl
index 0fb5c29..302e5e7 100644
--- a/lisp/sawfish/wm/windows.jl
+++ b/lisp/sawfish/wm/windows.jl
@@ -543,10 +543,14 @@ STATES has been changed. STATES may also be a single symbol."
 
   (define (rename-window-func window new-name)
     "Renames the WINDOW to NEW-NAME."
-    (set-x-text-property window 'WM_NAME (vector new-name))
-    (set-x-text-property window '_NET_WM_NAME (vector new-name))
-    (set-x-text-property window 'WM_ICON_NAME (vector new-name))
-    (set-x-text-property window '_NET_WM_ICON_NAME (vector new-name)))
+    ;; XXX required for gnome-panel. Need to check if KDE/XFCE are fine without or not.
+    (if (string-match desktop-environment "gnome")
+        (progn (set-x-text-property window 'WM_NAME (vector new-name))
+	       (set-x-text-property window 'WM_ICON_NAME (vector new-name))))
+      ;; XXX _NET_WM_VISIBLE_NAME doesn't have any effect?
+      (set-x-text-property window '_NET_WM_VISIBLE_NAME (vector new-name))
+      (set-x-text-property window '_NET_WM_NAME (vector new-name))
+      (set-x-text-property window '_NET_WM_ICON_NAME (vector new-name)))
 
   (define (rename-window-interactive w)
     (require 'sawfish.wm.util.prompt)
diff --git a/man/news.texi b/man/news.texi
index 5c666a4..e62a5f6 100644
--- a/man/news.texi
+++ b/man/news.texi
@@ -36,6 +36,10 @@ next workspace are now bundled in the new @code{Workspace} sub-menu.
 
 @item Sawfish emacs major-mode now indents let-fluids [Teika Kazura]
 
+ item @code{rename-window} function change [Christopher Bratusek]
+ code{rename-window} now also changes _NET_WM_VISIBILBE_NAME property.
+WM_NAME and WM_ICON_NAME are only changed, if @code{desktop-environment} is @code{gnome}.
+
 @item Translation related changes [Teika Kazura]
 
 @itemize +