Re: Byte compilation error.

On Sat, 29 May 2010 09:06:42 -0500, Jeremy Hankins wrote:
> Would you like me to go ahead and apply this version [of compilation
> error fix] to git, then?

No, thank you. What I said is our official attitude on 1.6.3, for
the rest of the world. I was responsible, and had to announce one.
Git is mainly for developers, and since you edit is ok, too, we don't
need a further action.

> I wonder if it's the raw order of the directory.

What was necessary was a compilation error fix, and let me forget the
file ordering issue. Many factors are there. @_@

>> 'requiring itself' [...]
> I was trying to decide if requiring the file might, e.g., hide
> legitimate errors that are introduced in the future.

I didn't notice that, but it must be almost ok. Remember, the trigger
of this error is the edit:
--- a/lisp/sawfish/wm/state/maximize.jl
+++ b/lisp/sawfish/wm/state/maximize.jl
-          sawfish.wm.state.shading
-         sawfish.wm.util.prompt)
+          sawfish.wm.state.shading)
Thus, util.prompt had been loaded "to itself" at byte compilation
after the long chain of module dependency.

>> 4. So, what to do?
> The unfinished part has nothing to do with prompt.jl; I can apply that
> anytime we decide it's time.  In fact, the sawfish that I run myself has
> this patch applied and has for months.  The problem is that it breaks
> backward-compatibility since it changes the way the prompt code is
> called.

We're not in hurry at all, but if you could do it, I'd appreciate it
deeply. Is it easy for you to write a rough documentation on the
usage? If it's supplied, then it's easy to update existent codes,
so there'll be no problem.

Teika (Teika kazura)

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]