Re: [PATCH] Re: Bug in Sawfish apps-menu.jl

[Christopher Roy Bratusek <zanghar freenet de>]

Am Tue, 09 Feb 2010 20:50:30 -0700
schrieb Matthew Love <matth love gmail com>:

> Teika Kazura <teika lavabit com> writes:
> 
> > (To: sawfish-list, cc: Matthew Love)
> > Hi, Matthew. We've got a bug in apps-menu.jl. I wonder if it would be
> > possible for you to fix it.
> >
> > It's that if erroneous *.desktop file or broken symlink is there, then
> > Sawfish doesn't start. An example of such file is:
> > https://bugzilla.gnome.org/attachment.cgi?id=152072
> >
> > How are you doing?
> >
> > With best regards,
> > Teika (Teika kazura)
> >
> >
> 
> Ok, it appears the culprit was the (read-from-string) function, which
> throws errors when the first character is a ";" or if a '#' is anywhere
> in the string.  This function was being called in the (build-cat-list)
> function to parse out the various categories.  It was a bad idea, and I
> had meant to change that a while ago, to use (read-from-string) for that
> purpose, as the (get-key-value) function used elsewhere in the
> apps-menu.jl was meant to replace its use.  It is now replaced and all should
> be well in that regard, a leading ";" should now return an empty string
> and as a result leave that entry out of the final list, but at least it
> won't crash anything.
> 
> As far as symlinks go, it might be best to ignore them completely, I've
> added this idea into the following patch, by checking if the file is a
> symlink initially along with the other checks in (generate-menu-entry),
> otherwise, that line in the patch can be ignored.
> 
> Cheers
> 
> 

Thanks Matthew, I've commited it (and closed the above bug).
Ignoring symlink seems fine to me.

Chris

-- 

Re: Regierung will Internet-Steuer einführen
Gesendet von Anonymous am Do, 6. Jul 2000 um 13:33

Nein !! Bitte Nicht ! ...
Was soll man denn dann als Schüler noch den INTERNET-*LUXUS* ich leisten können ??
Ja !! gebt ihm seine Frau wieder !