Re: [PATCH] make edge-flip work on resolution-change

Am Tue, 24 Aug 2010 07:59:48 +0900 (JST)
schrieb Teika Kazura <teika lavabit com>:

> On Fri, 13 Aug 2010 19:46:44 +0200, Christopher Roy Bratusek wrote:
> > 
> >> Chris, if you can, please XFree (? I'm not sure.) the old
> >> windows.
> > disable-flippers does already XUnmapWindow, so I'm not sure if we
> > would need besides it seems to work flawlessly like it is currently.
> Please call XDestroyWindow. It's tiniest, but a memory leak.

OK. Haven't yet checked for leaks.

> >> After restar-flipper is called, flippers are enabled even if 
> >> they were disabled. But I don't think it's your fault, but the
> >> original's. Chris, can you complete this task?
> > 
> > HEAD contains the proper fix (edge-flipping does not get accidently
> > activated anymore)
> No, registration to randr-hook has to be done in C. Flippers is used
> by infinite-desktop, too. (They can be used by any.) Distinction
> between src/flippers.c and wm/ext/edge-flip.jl is necessary.
> Thus your first patch sent to the ML was better in this regard.
> Teika (Teika kazura)

Registration in c-part enables edge-flipping even if the user disabled it.
I don't think there's a way to check user-variables in c (at least I haven't
seen it before.)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]