Re: [Patch] fix non-english letters in root-menu -> windows and window-menu->In group issue

[Christopher Roy Bratusek <zanghar freenet de>]

Am Mon, 01 Jun 2009 12:10:26 +0800
schrieb Wang Diancheng <dianchengwang gmail com>:

> >>>>> Christopher Roy Bratusek <zanghar freenet de> writes:
> 
>     > Am Sun, 31 May 2009 17:09:00 +0800 schrieb Wang Diancheng
>     > <dianchengwang gmail com>:
> 
>     >> Hi,
>     >> 
>     >> attachments fix non-english letters in non-root-menu -> windows
>     >> and
>     >> window-menu-> In group issue.
>     >> 
>     >> related Proposed Goals:
>     >> 
>     >> * Non-English Letters * CJK Letters
>     >> 
>     >> related bug:
>     >> 
>     >> 577913
>     >> 
>     >> This bug caused by function substring, when using this
>     >> function, it can lead to malformed UTF-8 characters.
>     >> 
>     >> I add a module to librep named utf8 located in 'rep.util.utf8',
>     >> which provide two function "utf8-string-length" and
>     >> "utf8-substring", then call them when extracting substring to
>     >> window-name.
>     >> 
>     >> Please review my patches, thanks.
>     >> 
>     >> Wang Diancheng
>     >> 
> 
>     >> Hi Wang,
> 
>     > long time ago I heard something from you :)
> 
>     > I Just tried it: and it's working!
> 
>     > While you're at UTF-8, could you try to fix the same issue in
>     > Sawfish-UI?
> 
>     > That would be great!
> 
>     > Thanks in advance, Chris
> 
> Hi, Christopher
> 
> I didn't read sawfish-ui code before, anyway, I'll try it.
> 

Hi,

... some more infos: I've marked all strings translatable (_ "string")
and they won't show up, if the widget is a label (if it's the GtkTree
or a GtkButton (GtkStock label), they are working properly), no matter
if containing non-utf8 chars or not, so sawfish-ui's i18n support is
badly broken on labels. One more thing: if you start sawfish with
LANG=en and want to start sawfish-ui with LANG=de you get both de and
en strings (I guess that's because sawfish-ui resets the lang not
correctly).

... I made a snapshot tarball for this change (as I don't want to fuck
up GIT): http://www.nanolx.org/free/sawfish-1.5.0-gamma.tar.bz2

make -C po update-po has been ran here.

Thanks for your efforts,
Chris