Re: [PATCH 1/3] Vala 0.5.0: Crash fix against selff==null in TrackerSelectionQuery::copy_str_list

[Cyrille Chépélov <cyrille chepelov keyconsulting fr>]

Le lundi 01 mars 2010 à 15:58 +0200, Zeeshan Ali (Khattak) a écrit :

> > while hacking a bit on Rygel, I encountered a few segfaults. Here's a quick patchset against those.
>
>   Thanks for the patch but it looks like a work around for some vala
> bug. Could you report the bug to vala please[1]?

In what sense is this a vala bug? Do you mean that valac should either:

1. refuse to compile the invocation of an instance method from a constructor, as in C# (in which case, my patch should stand)
2. tolerate the invocation of an instance method from a constructor, to the extent that that method refrains from using any instance resources (thus behaving as if it was static), in which case abstaining from emitting a g_assert(self != null)

Either way, TrackerSelectionQuery::copy_str_list() makes use of no instance resources; doesn't it thus makes sense to declare it static ?

>From what it's worth, the version of Vala used is 0.7.10.

    -- Cyrille