Re: A possible bug-fix

["Zeeshan Ali (Khattak)" <zeenix gmail com>]

On Thu, Oct 1, 2009 at 6:46 PM, Cem Eliguzel <celiguzel ubicom com> wrote:
> diff --git a/src/rygel/rygel-connection-manager.vala
> b/src/rygel/rygel-connection-manager.vala
>
> index f378131..a3ec5e4 100644
>
> --- a/src/rygel/rygel-connection-manager.vala
>
> +++ b/src/rygel/rygel-connection-manager.vala
>
> @@ -39,7 +39,11 @@ public class Rygel.ConnectionManager : Service {
>
>
>
>      protected string source_protocol_info {
>
>          owned get {
>
> -            return this.get_http_server ().get_protocol_info ();
>
> +            HTTPServer server = this.get_http_server ();
>
> +            if (server != null) {
>
> +                return server.get_protocol_info ();
>
> +            }
>
> +            return "";
>
>          }
>
>      }
>
>
>
> In my setup, when I run Rygel for the first time I got a segmentation fault.
> Only after adding the above code, I got rid of the segfault. Does this fix
> look reasonable?

  I take it the gst-renderer plugin was built and enabled? If so, yes
i have seen the segfault and investigating it was the first task on my
mind when i get back to gst-renderer. Thanks a lot for pinpointing the
issue for me already. :) You fix is good.

   If you'll be providing more patches in future, I suggest you setup
a clone of github repository somewhere and provide me the link. After
that each time, you just send me the commit hash.

-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124