Re: [Rhythmbox-devel] DACP (iTunes remote) support added

[Peter <rhythmbox-devel maubp freeserve co uk>]

On Mon, Oct 18, 2010 at 1:47 PM, Peter wrote:
> On Mon, Oct 18, 2010 at 12:43 PM, Jonathan Matthew <jonathan d14n org> wrote:
>>
>> I've just committed Alexandre Rosenfeld's work on adding DACP support,
>> after I finally got around to borrowing an iPhone from a friend to
>> test it out a bit. Apparently it won't work with iTunes remote 2.0,
>> but that's a fight for another day.
>>
>> If you'd like to test this out, you'll need a recent version of
>> libdmapsharing (I'd suggest building it from git master, as there are
>> likely to be bug fixes for this) and libsoup 2.32.x in addition to the
>> usual dependencies. If you were using a previous version of the code,
>> I should note that I changed the gconf key used to store the list of
>> paired devices, so you'll need to either re-pair, or update gconf
>> manually (/apps/rhythmbox/sharing/known-remotes ->
>> /apps/rhythmbox/plugins/daap/known-remotes).
>>
>> Thanks to Alexandre for working on this, and to Mike Petullo for
>> mentoring him and helping out with the code, and of course to the
>> Google Summer of Code people.
>
> Excellent news - I will be testing this once I've got RB built from source.
>

I'm building it on a 32 bit system and got this error:

  CC     libdaap_la-rb-daap-record.lo
cc1: warnings being treated as errors
rb-daap-record.c: In function ‘rb_daap_record_new’:
rb-daap-record.c:413: error: cast from pointer to integer of different size

The following one line fix makes it compile:

$ git diff
diff --git a/plugins/daap/rb-daap-record.c b/plugins/daap/rb-daap-record.c
index fee6064..d8e5740 100644
--- a/plugins/daap/rb-daap-record.c
+++ b/plugins/daap/rb-daap-record.c
@@ -409,7 +409,7 @@ RBDAAPRecord *rb_daap_record_new (RhythmDBEntry *entry)
                                                (entry, RHYTHMDB_PROP_ALBUM);

                /* Since we don't support album id's on Rhythmbox,
"emulate" it */
-               record->priv->albumid  = (gint64) rhythmdb_entry_get_refstring
+               record->priv->albumid  = (gint) rhythmdb_entry_get_refstring
                                                (entry, RHYTHMDB_PROP_ALBUM);

                record->priv->genre    = rhythmdb_entry_dup_string


Is this a sane fix?

Peter