Re: [Rhythmbox-devel] patch for search entry

[Charles Schmidt <cschmidt2 emich edu>]

On Sun, 2005-09-11 at 23:33 +0300, ÐÐÐÑÐÑ ÐÐÐÑÑÐÑÐÐ wrote:
> Looks very promising. I would also add a search for the filepath, so
> that only the ogg files are selected or only the files in directory foo,
> for instance. (which unfortunately doesn't work witht the current
> search)

Why?  To me, my music just my music, I'm not too concerned what format
its in.  Also, since there is no way to view the filepath in the track
listing, it would be very confusing for someone who (unbeknownst to
them) has their music in multiple formats, searches for "ogg" (dunno,
perhaps theres a song or an artist with that in its name), and a lot of
music is listed that doesn't appear to match that criteria.

As for the directory, again, why?  Aren't these implementation details
that shouldn't be exposed to the user?

-charlie

> On Sat, 2005-09-10 at 17:18 -0400, Charles Schmidt wrote:
> > -
> > Hello,
> > 
> > Attached is a patch against CVS for the search entry that does two
> > things:
> > 
> > * Adds an icon that when pressed drops down a menu, allowing you to
> > select what to search (All, Artists, Albums, Songs).  The code that
> > would make the selection actually work has not been written yet, I
> > thought it better to get comments on this before I spend time doing
> > that.
> > 
> > * Adds and icon that when pressed clears the search entry ("clear
> > button")
> > 
> > You can see the new search entry here:
> > http://ishamael.inactivex.net/images/rb-new-search-entry.png
> > 
> > To get the effect of the icons in the entry, I've borrowed epiphany's
> > ephy-icon-entry widget.  
> > 
> > This is a request for comments & suggestions regarding this patch.  I
> > think these would be nice features, but I understand there has been some
> > debate in the past about a clear button, perhaps this new way (as
> > opposed to a large GtkButton) sovles it?
> > 
> > If there is a positive response, I'll go ahead and tie in the search
> > type so that your selection actually works, and commit it (with walters'
> > approval, of course).
> > 
> > Thanks,
> > -charlie
> > 
> > _______________________________________________
> > rhythmbox-devel mailing list
> > rhythmbox-devel gnome org
> > http://mail.gnome.org/mailman/listinfo/rhythmbox-devel
> 
> _______________________________________________
> rhythmbox-devel mailing list
> rhythmbox-devel gnome org
> http://mail.gnome.org/mailman/listinfo/rhythmbox-devel