Re: [Rhythmbox-devel] [patch] tray icon rework patch

[Peter Robinson <pbrobinson gmail com>]

On 8/31/05, Colin Walters <walters verbum org> wrote:

Hi,

Here's an updated patch which only does the minimization if you have a
notification area, and also has what I think are better rules for
handling clicks on the icon.  Now it always presents the window if it
doesn't have focus, and only does the minimization if the window doesn't
have focus.

Can people play around with this and see how it feels?

Hi Colin,

Went to have a play with it but when making a rpm my build barfs. This is due to the the dbus services change that happened a couple of days ago. I feel I need a PREFIX or something in there so that it doesn't try to install it directly into /usr when building the package but I aren't sure. Other than that builds OK on FC4 for me :-)

Cheers,
Pete

 /usr/bin/install -c -m 644 rhythmbox.schemas /var/tmp/rhythmbox-0.9.0-root/etc/gconf/schemas/rhythmbox.schemas
/bin/sh ../mkinstalldirs /var/tmp/rhythmbox-0.9.0-root/usr/lib/bonobo/servers
 /usr/bin/install -c -m 644 GNOME_Rhythmbox.server /var/tmp/rhythmbox-0.9.0-root/usr/lib/bonobo/servers/GNOME_Rhythmbox.server
/bin/sh ../mkinstalldirs /usr/share/dbus-1/services
 /usr/bin/install -c -m 644 org.gnome.Rhythmbox.service /usr/share/dbus-1/services/org.gnome.Rhythmbox.service
/usr/bin/install: cannot create regular file `/usr/share/dbus-1/services/org.gnome.Rhythmbox.service': Permission denied
make[3]: *** [install-serviceDATA] Error 1
make[3]: Leaving directory `/usr/src/redhat/BUILD/rhythmbox-0.9.0/data'
make[2]: *** [install-am] Error 2
make[2]: Leaving directory `/usr/src/redhat/BUILD/rhythmbox-0.9.0/data'
make[1]: *** [install-recursive] Error 1
make[1]: Leaving directory `/usr/src/redhat/BUILD/rhythmbox-0.9.0/data'
make: *** [install-recursive] Error 1