Hi, Le vendredi 03 juin 2005 à 09:13 +1000, Jonathan Matthew a écrit : > > Fwiw, I grabbed jonathan's --bugs-- branch as separate patches and > > started to review them individually, I have selected 60/70% of those > > which can go into mainline as is, and I still have to look more > > carefully at the other ones. > > Thanks! I wasn't looking forward to going through all of that. > Please let me know if there's anything I can do to help here. I know my > patch summaries aren't very descriptive, so I might need to clarify some > things. I put the patches that look fine to me at http://cfergeau.free.fr/rb-patches/ http://cfergeau.free.fr/rb-patches/remaining/ contains the patches I still need to look at (unsurprisingly, those are the biggest ones ;) The only patch I didn't like so far is patch-10, see below for the notes I took at the time : --- orig/configure.ac +++ mod/configure.ac @@ -38,6 +38,8 @@ PKG_PROG_PKG_CONFIG +PKG_PROG_PKG_CONFIG + Unneeded +if USE_CD_BURNER +librbplayer_la_SOURCES += \ + rb-recorder.h \ + rb-recorder-gst.c + +INCLUDES += $(LIBNAUTILUS_BURN_CFLAGS) + This breaks the xine backend, which I removed from my playbin branch but still seems to be present in the bug branch, so it's not really a big issue, but still ;) Christophe
Attachment:
signature.asc
Description: This is a digitally signed message part