[Rhythmbox-devel] Small fix for no dbus compile and question

Hi All,

Attached is a small fix for compiling on FC4 with out the new dbus
support (it was missing a ifdef and had an unused var).

Also a quick query, a recent commit added a call to
gtk_window_present_with_time which from what I can tell was introduced
in gtk 2.8. From memory there was discussion about having the core
rhythmbox functionality depend on the older libs so it can be run from
gnome 2.10 or  something but the more advanced functionality such as
dbus relying on the newer versions of the libraries that ship with
gnome 2.12. Is this still going to be the case? I feel an upgrade to
rawhide coming :-)

--- rhythmbox-0.9.0/shell/main.c	2005-08-26 08:50:35.000000000 +0100
+++ rhythmbox-0.9.0.mod/shell/main.c	2005-08-26 09:58:52.000000000 +0100
@@ -105,10 +105,11 @@
 main (int argc, char **argv)
 	GnomeProgram *program;
+#ifdef WITH_DBUS
 	DBusGConnection *session_bus;
 	RBShell *rb_shell;
 	char **new_argv;
-	GError *error = NULL;
 	RBRemoteClientProxy *client_proxy;
 	gboolean activated;
 	poptContext poptContext;

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]